[PATCH] D132696: [ELF] Provide the GNU hash function in libObject

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 26 00:26:31 PDT 2022


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, but don't land this without the other patches in the stack being accepted.

I'm not sure I understand @MaskRay's objection to removing it from LLD at the same time. There doesn't seem to be any benefit from having the code in two places, given that it's not made the rest of the LLD code more complex.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132696/new/

https://reviews.llvm.org/D132696



More information about the llvm-commits mailing list