[PATCH] D130466: [LICM] - Add option to allow data races

[Shubham Narlawar via Phabricator via llvm-commits]

gsocshubham added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfoImpl.h:112
 
+  ThreadModel::Model getThreadModel() const { return ThreadModel::POSIX; }
+
----------------
What should be the return value here? Should it be `ThreadModel::INVALID` or should I keep it same?

Should I add a new value to existing enum like below?

```
  namespace ThreadModel {
    enum Model {
      INVALID // Thread model not known?
      POSIX,  // POSIX Threads
      Single  // Single Threaded Environment
    };
  }
```

Above enum is defined in `llvm/Target/TargetOptions.h`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130466/new/

https://reviews.llvm.org/D130466