[PATCH] D132282: [LoongArch] Override TargetLowering::hasAndNot()

Gong LingQin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 21 19:16:27 PDT 2022


gonglingqin added a comment.

In D132282#3737840 <https://reviews.llvm.org/D132282#3737840>, @xen0n wrote:

> The changes LGTM but the patch title could be a bit more specific. "Override hasAndNot" is "what you have done", but we generally prefer "what you intend to do by making this change" -- description of your intent.
>
> I think a title like "Implement TargetLowering::hasAndNot for more optimization chances" could be better.

Thanks, I will change it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132282/new/

https://reviews.llvm.org/D132282



More information about the llvm-commits mailing list