[PATCH] D79483: [CostModel] Replace getUserCost with getInstructionCost.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 18 02:19:42 PDT 2022


RKSimon added a comment.

In D79483#3731290 <https://reviews.llvm.org/D79483#3731290>, @dmgreen wrote:

> This is mostly expected to have minimal impact on the decisions the compiler makes, right? Most of the changes are in latency, which are not used very much in heuristics.

That's correct - the select-optimize pass is the only one that really tries to use it so far, and that's still disabled by default until the costs have been improved.

> I ran some benchmarks and (after fixing what I got wrong the first time), it looks OK.

👍


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79483/new/

https://reviews.llvm.org/D79483



More information about the llvm-commits mailing list