[PATCH] D129636: Fix a LSR debug invariance issue

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 11 02:08:07 PDT 2022


mkazantsev requested changes to this revision.
mkazantsev added a comment.
This revision now requires changes to proceed.

Did you consider that `forgetValue` in fact does not only forget the value you are aiming, but also all its users recursively? Imagine that some of the users had no-wrap flags inferred from other queries. Now you forget it, and the flags get lost. Won't this introruce a similar issue in another place?

The best alternative I can suggest is to create a new ScalarEvolution instance and use it for dbg value queries.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129636/new/

https://reviews.llvm.org/D129636



More information about the llvm-commits mailing list