[PATCH] D130913: [ARM] Parse Tag_also_compatible_with attribute

Lucas Prates via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 8 01:53:38 PDT 2022


pratlucas added inline comments.


================
Comment at: llvm/lib/Support/ARMAttributeParser.cpp:438
+      Description = strings[InnerValue];
+  }
+
----------------
Should other tags be handled here too, in a more gereric way? 
The ABI specifies that the inner values can be either an ULEB128 value or an NTBS string. It would be useful to have these presented in a decoded way in adition to the raw string.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130913/new/

https://reviews.llvm.org/D130913



More information about the llvm-commits mailing list