[PATCH] D123693: Transform illegal intrinsics to V_ILLEGAL

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/v_illegal-atomics.ll:40
+; GFX906-OBJ:      s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
+; GFX906-OBJ-NEXT: v_illegal // 000000000004: FFFFFFFF
+
----------------
Leonc wrote:
> arsenm wrote:
> > This looks backwards. gfx10 is getting the -1 encoding and gfx9 is getting 0
> Are you sure gfx9 is getting the zero encoding? I thought this line was "address: encoding".
> If this was wrong wouldn't the tests in `v_illegal-atomics.s` also be wrong?
You're right, gfx9 looks right. The gfx1030 line with .long 0xffffffff looks wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123693/new/

https://reviews.llvm.org/D123693