[PATCH] D131250: [scudo] Try to fix standalone build on armv7

[Diana Picus via Phabricator via llvm-commits]

rovka created this revision.
rovka added reviewers: phosek, cryptoad, Naville, abrachet, ddcc.
Herald added subscribers: Enna1, kristof.beyls, mgorny.
Herald added a project: All.
rovka requested review of this revision.
Herald added a project: Sanitizers.
Herald added a subscriber: Sanitizers.

When linking scudo standalone on armv7, it can't find symbols related to
unwinding (e.g. __aeabi_unwind_cpp_pr0). This is probably because it 
is passing --unwindlib=none. This patch hacks around the issue by adding
COMPILER_RT_UNWINDER_LINK_LIBS if we're using the LLVM unwinder.

I don't know anything about scudo, so I'm not sure what the original
intention was.

This is a release blocker.
See also https://github.com/llvm/llvm-project/issues/56900


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D131250

Files:
  compiler-rt/lib/scudo/standalone/CMakeLists.txt


Index: compiler-rt/lib/scudo/standalone/CMakeLists.txt
===================================================================
--- compiler-rt/lib/scudo/standalone/CMakeLists.txt
+++ compiler-rt/lib/scudo/standalone/CMakeLists.txt
@@ -137,6 +137,9 @@
 
 set(SCUDO_LINK_LIBS)
 
+append_list_if(COMPILER_RT_USE_LLVM_UNWINDER ${COMPILER_RT_UNWINDER_LINK_LIBS}
+               SCUDO_LINK_LIBS)
+
 append_list_if(COMPILER_RT_HAS_LIBPTHREAD -pthread SCUDO_LINK_FLAGS)
 
 append_list_if(FUCHSIA zircon SCUDO_LINK_LIBS)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D131250.450261.patch
Type: text/x-patch
Size: 508 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220805/6f738cfe/attachment.bin>