[PATCH] D130912: [InstCombine] Correct strtol folding with nonnull endptr

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 1 12:18:50 PDT 2022


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:93
+  // Current offset into the original string to reflect in EndPtr.
+  unsigned Offset = 0;
   // Strip leading whitespace.
----------------
Please use size_t here.  (Not that it's really likely to matter here, but for the sake of clarity.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130912/new/

https://reviews.llvm.org/D130912



More information about the llvm-commits mailing list