[PATCH] D119412: github: Automatically create backport requests for bugs referenced in commit messages

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 28 11:45:19 PDT 2022


tstellar added inline comments.


================
Comment at: llvm/utils/git/github-automation.py:282
+                    title
+                    timelineItems (itemTypes: [CLOSED_EVENT], last: 1) {
+                        edges {
----------------
kwk wrote:
> This is cool. It looks like you've taken into account that an issue could be closed and reopened. But I wonder if it is enough to just focus on the last close event. What if you close an issue with a commit but missed out and edge case and later create a fixup commit. This will not be covered here but afterall we're humans and need to judge. This is just a nudge in the right direction I guess.
I'm just trying to get the closed event that triggered the workflow run.  If there is another closed event  later, it should trigger a new workflow and that workflow will be able to pick up any commits.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119412/new/

https://reviews.llvm.org/D119412



More information about the llvm-commits mailing list