[PATCH] D130217: [Kaleidoscope] Fix DWARF function creation example

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 25 11:21:21 PDT 2022


dblaikie added a subscriber: tstellar.
dblaikie added a comment.

In D130217#3676841 <https://reviews.llvm.org/D130217#3676841>, @jzbrooks wrote:

> Thanks @dblaikie. I don’t have commit access, can you land this patch for me? Please use “Justin Brooks justin at jzbrooks.com” to commit the change.

Sure, done!

> I also wonder if this change would be beneficial to land in other branches as well. I was working with LLVM 11 (going to update it soon, hopefully), so when I encountered the problem the full code listing wasn't addressed either. I had to read LLVM source to figure out how to fix the problem. I'm happy to do that, but I'm not sure if there's a process for such things or if it would be valuable.

@tstellar - any thoughts on whether it's suitable/worthwhile to backport this documentation fix?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130217/new/

https://reviews.llvm.org/D130217



More information about the llvm-commits mailing list