[PATCH] D130370: [llvm] Always use Constant for FP_ROUND ISD Nodes

David Truby via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 22 09:37:17 PDT 2022


DavidTruby created this revision.
Herald added subscribers: kosarev, jsilvanus, ctetreau, foad, kerbowa, hiraditya, kristof.beyls, nhaehnle, jvesely, arsenm.
Herald added a project: All.
DavidTruby requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This patch ensures consistency in the construction of FP_ROUND nodes
such that they always use ISD::Constant instead of ISD::TargetConstant.

This additionally fixes a bug in the AArch64 SVE backend where patterns
were matching against TargetConstant nodes and sometimes failing when
passed a Constant node.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D130370

Files:
  llvm/include/llvm/CodeGen/ISDOpcodes.h
  llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td
  llvm/lib/Target/AArch64/SVEInstrFormats.td
  llvm/lib/Target/AMDGPU/SIISelLowering.cpp
  llvm/test/CodeGen/AArch64/sve-fcopysign.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130370.446874.patch
Type: text/x-patch
Size: 11290 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220722/7da8bd5e/attachment.bin>


More information about the llvm-commits mailing list