[PATCH] D127115: [RFC][DAGCombine] Make sure combined nodes are added back to the worklist in topological order.

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 21 03:34:28 PDT 2022


barannikov88 added a comment.

Just to make it clear. Does the topological order here mean that the DAG will be traversed from the root to leaves (RPO) or from the leaves to the root (PO)? From the definition of topological sorting it should be the former, while the latter seems to be more beneficial, as it would simplify operands of the currently visited node, which, in turn, should make optimizing the node easier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127115/new/

https://reviews.llvm.org/D127115



More information about the llvm-commits mailing list