[PATCH] D130164: [LV] Support predicated div/rem operations via safe-divisor select idiom

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In D130164#3666366 <https://reviews.llvm.org/D130164#3666366>, @efriedma wrote:

> Sure, I didn't mean we should block this patch until we come up with the ideal solution.  Just thought it was worth bringing up since you didn't mention it as a strategy.

Fair point, added it to the strategy list above.

A random thoughts on this, just for possible future reference: "does not fault" does not always mean "is always fast".  I'm not sure of the details here, but I've run into cases like this in the fast where the non-faulting behavior was so poor performance wise you had to avoid it anyways.  This would be something we'd need to check for when specifying the udiv variant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130164/new/

https://reviews.llvm.org/D130164