[PATCH] D128626: [llvm-ar] Add --output to specify output directory

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one suggestion.



================
Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:471
+    if (!IsDir)
+      fail(OutputDir + " is not a directory");
+  }
----------------
`OutputDir` probably should be quoted in case there are any spaces in the path.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128626/new/

https://reviews.llvm.org/D128626