[PATCH] D127166: [DirectX] Add DirectX target object writer

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 10 14:49:58 PDT 2022


MaskRay added inline comments.


================
Comment at: llvm/lib/Target/DirectX/DirectXTargetMachine.cpp:107
+      if (!MMIWP) {
+        MMIWP = new MachineModuleInfoWrapperPass(this);
+      }
----------------
remove braces https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements


================
Comment at: llvm/lib/Target/DirectX/MCTargetDesc/DirectXContainerObjectWriter.cpp:20
+class DirectXContainerObjectWriter : public MCDXContainerTargetWriter {
+
+public:
----------------
delete blank line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127166/new/

https://reviews.llvm.org/D127166



More information about the llvm-commits mailing list