[PATCH] D126722: [BOLT][NFC] Warning for deprecated option '-reorder-blocks=cache+'

Maksim Panchenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 1 14:01:20 PDT 2022


maksfb accepted this revision.
maksfb added inline comments.


================
Comment at: bolt/lib/Passes/BinaryPasses.cpp:190
+            << "'-reorder-blocks=cache+' is deprecated, "
+            << "please use '-reorder-blocks=ext-tsp' instead.\n";
+        ReorderBlocks = bolt::ReorderBasicBlocks::LT_OPTIMIZE_EXT_TSP;
----------------
You should drop the trailing period in the message according to LLVM guidelines. Otherwise LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126722/new/

https://reviews.llvm.org/D126722



More information about the llvm-commits mailing list