[PATCH] D125969: [InstCombine] Prevent the transform of the comparison for all undef elements

Allen zhong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 20 19:35:19 PDT 2022


Allen added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/icmp-bc-vec-inseltpoison.ll:129
+
+; Verify the case that all elements are under define
+define <4 x i1> @test_i32_ule_pattern(i32 %val) {
----------------
paulwalker-arm wrote:
> `Verify the case when all elements are undefined.`
> 
> Not sure if I've missed some detail but when I run this test using an upstream pull from this morning I achieve the same output you're matching against here without needing this patch?
Oh, sorry, my bad.  I work with old commit dd644ddf8 before, and now the new upstream seem work fine, and don't need such work around


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125969/new/

https://reviews.llvm.org/D125969



More information about the llvm-commits mailing list