[PATCH] D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section.

[Kan Shengchen via Phabricator via llvm-commits]

skan added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-bbaddrmap-disassemble-symbolize-operands.yaml:21
+# ATT-NEXT: <BB1>:
+# ATT-NEXT:   cmpl  , %eax <symbol>
+# ATT-NEXT:   nop
----------------
MaskRay wrote:
> skan wrote:
> > The memory operand of cmpl disappears here. Is it on purpose?
> --symbolize-operands only works with -M intel. The -M att support is quite broken but having the test helps we know the current state.
I see. Thanks for the clarifying it.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:991
+    return;
+  Labels.clear();
+  uint64_t StartAddress = SectionAddr + Start;
----------------
Do we need this `clear`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124560/new/

https://reviews.llvm.org/D124560