[PATCH] D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed.

[Aman LaChapelle via Phabricator via llvm-commits]

bzcheeseman marked 3 inline comments as done.
bzcheeseman added inline comments.


================
Comment at: llvm/include/llvm/Support/Casting.h:313
+template <typename OptionalDerived, typename Default>
+using SelfType = std::conditional_t<std::is_same<OptionalDerived, void>::value,
+                                    Default, OptionalDerived>;
----------------
rriddle wrote:
> Can we put this in detail? or a `cast_impl` namespace?
Yes nice catch, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123901/new/

https://reviews.llvm.org/D123901