[PATCH] D123897: [X86] Unbreak LIT/FileCheck

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 16 10:36:47 PDT 2022


lebedev.ri added a comment.

In D123897#3455435 <https://reviews.llvm.org/D123897#3455435>, @mtrofin wrote:

> In D123897#3455433 <https://reviews.llvm.org/D123897#3455433>, @lebedev.ri wrote:
>
>> In D123897#3455425 <https://reviews.llvm.org/D123897#3455425>, @mtrofin wrote:
>>
>>> Added David back - he had some concerns and a good (I think) suggestion. Could this patch do his “UTC_ARGS: —allow-unused-prefixes” suggestion instead? Seems it wouldn't be any bigger of a change, and I think everybody would have their concerns addressed.
>>
>> Everybody except me? :)
>
> My understanding is that his proposal will make any test generated with one of the auto-generators automatically enrolled into --allow-unused-prefixes. Wouldn't that address your scenario?



1. It's a workaround for the case of unchanged default. I'm interested in fixing the default, not workarounding it.
2. `UTC_ARGS` controls the default arguments for the `update_llc_test_checks.py` family of checks. Can you please explain how it would happen to affect the FileCheck? Should `update_llc_test_checks.py` rewrite the RUN lines? Or would FileCheck itself  need to be modified to somehow look for it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123897/new/

https://reviews.llvm.org/D123897



More information about the llvm-commits mailing list