[PATCH] D122291: [VP] Add more cast VPintrinsic and docs.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

Verifier.cpp needs to be updated to verify the element counts match between the source and destination and that they have integer/fp types where they should. fpext, fptrunc, trunc, zext, and sext also need to verify that the element size is increasing/decreasing like its supposed to.



================
Comment at: llvm/docs/LangRef.rst:20686
+extending that value to the size of the integer type.
+If ``value`` is smaller than return type then a zero extension is done. If
+``value`` is larger than return type then a truncation is done. If they are
----------------
"type then" -> "type, then"


================
Comment at: llvm/docs/LangRef.rst:20687
+If ``value`` is smaller than return type then a zero extension is done. If
+``value`` is larger than return type then a truncation is done. If they are
+the same size, then nothing is done (*no-op cast*) other than a type
----------------
Here too


================
Comment at: llvm/docs/LangRef.rst:20742
+applying either a zero extension or a truncation depending on the size of the
+integer ``value``. If ``value`` is larger than the size of a pointer then a
+truncation is done. If ``value`` is smaller than the size of a pointer then a
----------------
"pointer then" -> "pointer, then"


================
Comment at: llvm/docs/LangRef.rst:20743
+integer ``value``. If ``value`` is larger than the size of a pointer then a
+truncation is done. If ``value`` is smaller than the size of a pointer then a
+zero extension is done. If they are the same size, nothing is done (*no-op cast*).
----------------
Here too


================
Comment at: llvm/include/llvm/IR/VPIntrinsics.def:302
 // chain = EXPERIMENTAL_VP_STRIDED_STORE chain,val,base,offset,stride,mask,evl
-BEGIN_REGISTER_VP_SDNODE(EXPERIMENTAL_VP_STRIDED_STORE, 0, experimental_vp_strided_store, 5, 6)
+BEGIN_REGISTER_VP_SDNODE(EXPERIMENTAL_VP_STRIDED_STORE, 0,
+                         experimental_vp_strided_store, 5, 6)
----------------
Usually you shouldn't make formatting changes to code you aren't touching. If you want to extract this from this patch and just commit it, that would be fine.


================
Comment at: llvm/include/llvm/IR/VPIntrinsics.def:327
 // chain = EXPERIMENTAL_VP_STRIDED_LOAD chain,base,offset,stride,mask,evl
-BEGIN_REGISTER_VP_SDNODE(EXPERIMENTAL_VP_STRIDED_LOAD, -1, experimental_vp_strided_load, 4, 5)
+BEGIN_REGISTER_VP_SDNODE(EXPERIMENTAL_VP_STRIDED_LOAD, -1,
+                         experimental_vp_strided_load, 4, 5)
----------------
Same here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122291/new/

https://reviews.llvm.org/D122291