[PATCH] D120811: [Dominators] Don't treat multi-edge as dominating

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added a comment.

I'm not too sure about the semantics either. I think it might be easier to think about if we tie this back to regular graphs without multi-edges.

My guess is that the original intention was to treat multi-edges as the same logical graph edge. With this abstraction, the existing behavior seems correct to me.

What you are proposing sounds to me similar to adding a virtual node in the middle of each duplicate edge. Is this a reasonable interpretation? If yes, this patch would appear fine to me, but I'm not sure if it's logically consistent with all the other code that may still rely on the old abstraction.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120811/new/

https://reviews.llvm.org/D120811