[PATCH] D121402: [X86][NFC] Move table from getRelaxedOpcodeArith into its own class

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 11 22:09:38 PST 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86InstrRelaxTables.cpp:16
+#include "llvm/ADT/STLExtras.h"
+#include <vector>
+
----------------
Don't vector since you switched to SmallVector


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86InstrRelaxTables.cpp:132
+
+    sort(Table.begin(), Table.end());
+
----------------
MaskRay wrote:
> `llvm::sort(Table)`
Does `sort(Table)` work?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121402/new/

https://reviews.llvm.org/D121402



More information about the llvm-commits mailing list