[PATCH] D116220: [AIX][XCOFF] address post-commit review comments of patch https://reviews.llvm.org/D82549

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 9 23:00:43 PST 2022


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, but you probably want someone else with XCOFF experience to discuss the warning. As noted earlier inline, I don't think a warning in "regular" usage makes sense, since this warning will always be emitted and there's nothing the user can do about it. However, it's possible it means there's extra data that llvm-readobj might be intended to interpret that it isn't, I don't know.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116220/new/

https://reviews.llvm.org/D116220



More information about the llvm-commits mailing list