[PATCH] D120994: [Coroutines] Allow FramePtr to be an Argument

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 6 18:09:38 PST 2022


ChuanqiXu accepted this revision.
ChuanqiXu added a comment.
This revision is now accepted and ready to land.

LGTM except a nit.



================
Comment at: llvm/lib/Transforms/Coroutines/CoroInternal.h:270
 
+  Instruction *getAfterFramePtrInsertPt() const {
+    if (auto *I = dyn_cast<Instruction>(FramePtr))
----------------
I prefer `getInsertPtAfterFramePtr`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120994/new/

https://reviews.llvm.org/D120994



More information about the llvm-commits mailing list