[PATCH] D120819: [flang] Handle module in lowering pass

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 2 09:18:21 PST 2022


clementval added inline comments.


================
Comment at: flang/lib/Lower/Bridge.cpp:62-71
+    //  - Declare all functions that have definitions so that definition
+    //    signatures prevail over call site signatures.
+    //  - Define module variables and OpenMP/OpenACC declarative construct so
+    //    that they are available before lowering any function that may use
+    //    them.
     for (Fortran::lower::pft::Program::Units &u : pft.getUnits()) {
       std::visit(
----------------
PeteSteinfeld wrote:
> With these changes, I'm getting differences after running clang-format.
Ok I'll double check that. Thanks for the heads up. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120819/new/

https://reviews.llvm.org/D120819



More information about the llvm-commits mailing list