[PATCH] D72643: [InstCombine] form copysign from select of FP constants (PR44153)

[Sanjay Patel via Phabricator via llvm-commits]

spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:2358
+  Instruction *CopySign = IntrinsicInst::Create(F, { MagArg, X });
+  CopySign->setFastMathFlags(Sel.getFastMathFlags());
+  return CopySign;
----------------
RKSimon wrote:
> @spatel https://github.com/llvm/llvm-project/issues/54077 suggests that we shouldn't pass forward the FMF
Thanks for tracking it down!
Should be fixed with:
84812b9b072a


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72643/new/

https://reviews.llvm.org/D72643