[PATCH] D117765: [AMDGPU][GlobalISel] Select source modifiers for VOP3Opsel

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 21 18:31:50 PST 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:3666
+    if (Mods != 0)
+        return {};
+  } else {
----------------
Formatting


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:3669
+    const MachineInstr *Def = getDefIgnoringCopies(Reg, *MRI);
+    if (Def && (Def->getOpcode() == AMDGPU::G_FNEG ||
+                Def->getOpcode() == AMDGPU::G_FABS))
----------------
Def can't fail


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117765/new/

https://reviews.llvm.org/D117765



More information about the llvm-commits mailing list