[PATCH] D119901: [Debuginfod] Add BUILD_ID syntax to llvm-symbolizer.

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-symbolizer.rst:31
 
+Prefixing the above with "BUILD_ID" causes the object file to be interpreted as
+a hex build ID rather than a path. This will look up the corresponding debug
----------------
jhenderson wrote:
> I have a marginal preference for `BUILDID` (withotu the underscore), as I dislike typing underscores. I don't feel strongly about this though, so if you prefer with the underscore, that's fine.
> 
> The use of the term "object file" seems a bit unintuitive here though, since a build ID is neither an object file itself, nor a path to one. Perhaps it would be better to rephrase the references to "object file" earlier in this section with "input name" or similar, then here, I'd start this paragraph with something like "By default, input names are interpreted as object file paths. However, prefixing the command with ...". Finally, I'd then put this paragraph second or third in order in this section.
Could we reverse the order and instead do something like:

```
[CODE] [FILE:]<file> <address>
DATA [FILE:]<file> <address>
[CODE] BUILDID:<build ID> <address>
DATA BUILDID:<build ID> <address>
```

This would avoid the confusion between file and build ID.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119901/new/

https://reviews.llvm.org/D119901