[PATCH] D119074: [ELF] Parse archives as --start-lib object files

Tue Feb 15 09:57:34 PST 2022

MaskRay added a comment.

In D119074#3323417 <https://reviews.llvm.org/D119074#3323417>, @bd1976llvm wrote:

> I am slightly concerned about penalising links with low utilisation archives. However, I don't have any specific data on low utilisation archives or any example of them. We did do some testing of a similar feature (in our proprietary linker) on game code, and low utilisation archives did not cause a problem for any of the games tested. Users should be able to create high utilisation versions of problematic archives in any case.
>
> LGTM from me.

I think the utilization ratio needs to be quite low to observe a performance loss (I guess for 50% utilization with regular defined-vs-undefined ratio, it's still a net win). Even in that case the performance loss can be restored by parallel input file scanning (https://discourse.llvm.org/t/parallel-input-file-parsing/60164).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119074/new/

https://reviews.llvm.org/D119074