[PATCH] D119278: [LLD] Fix issue in HIP toolchain due to unspecified order of evaluation of the function object

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 8 16:17:30 PST 2022


aganea marked 2 inline comments as done.
aganea added inline comments.


================
Comment at: lld/test/ELF/amdgpu-duplicate-sym.s:9
+        .amdgcn_target "amdgcn-amd-amdhsa--gfx1031"
+        .p2alignl 6, 3214868480
+        .fill 48, 4, 3214868480
----------------
MaskRay wrote:
> Remove unneeded directives like `.p2alignl`, `.fill`, `.size`
Both comments fixed in the commit, thanks for reviewing!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119278/new/

https://reviews.llvm.org/D119278



More information about the llvm-commits mailing list