[PATCH] D110579: [AMDGPU] Add a new intrinsic to control fp_trunc rounding mode

[Julien Pagès via Phabricator via llvm-commits]

jpages marked 3 inline comments as done.
jpages added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:6355
+
+    SmallVector<EVT, 4> ValueVTs;
+    ComputeValueVTs(TLI, DAG.getDataLayout(), I.getType(), ValueVTs);
----------------
craig.topper wrote:
> You probably don't need ComputeValueVTs. There shouldn't be any structs or arrays here that need to broken down. I think you can do
> 
> ```
> EVT VT = TLI.getValueType(I.getType)
> ```
> 
> And then use `VT` in place of `VTs`
Indeed it works, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110579/new/

https://reviews.llvm.org/D110579