[PATCH] D118071: [SystemZ][z/OS]: fix lit tmp_dir to use - instead of _

Nancy Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 24 14:17:10 PST 2022


NancyWang2222 added a comment.

In D118071#3267521 <https://reviews.llvm.org/D118071#3267521>, @yln wrote:

> Exact spelling of the temporary test directory shouldn't matter.
> The  z/OS linker not being able to handle this sounds like a bug... but oh my.
>
> Nit: can we make the comment more compact, maybe:
>
>   tmp_dir = tempfile.mkdtemp(prefix='lit-tmp-')  # z/OS linker does not support '_' in paths, so use '-'
>
> LGTM, thanks!

sure. I will update comments


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118071/new/

https://reviews.llvm.org/D118071



More information about the llvm-commits mailing list