[PATCH] D118068: [OpenMP] Add more identifier to created shared globals

Joseph Huber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 24 12:50:33 PST 2022


jhuber6 created this revision.
jhuber6 added reviewers: tianshilei1992, jdoerfert.
Herald added subscribers: ormris, guansong, hiraditya, yaxunl.
jhuber6 requested review of this revision.
Herald added subscribers: llvm-commits, sstefan1.
Herald added a project: LLVM.

Currenly we push some variables to a global constant containing shared
memory as an optimization. This generated constant had internal linkage
and should not have collided with any known identifiers in the
translation unit. However, there have been observed cases of this
optimiztaion unintentionally colliding with undocumented PTX
identifiers. This patch adds a suffix to the created globals to
hopefully bypass this.

Depends on D118059 <https://reviews.llvm.org/D118059>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D118068

Files:
  llvm/lib/Transforms/IPO/OpenMPOpt.cpp
  llvm/test/Transforms/OpenMP/replace_globalization.ll
  llvm/test/Transforms/OpenMP/spmdization.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118068.402631.patch
Type: text/x-patch
Size: 26229 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220124/4ef94747/attachment.bin>


More information about the llvm-commits mailing list