[PATCH] D116714: AMDGPU: Fix LiveVariables error after optimizing VGPR ranges

Ruiling, Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 10 06:35:58 PST 2022


ruiling accepted this revision.
ruiling added a comment.
This revision is now accepted and ready to land.

LGTM with one minor comment.



================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp:377-384
   MachineBasicBlock *ThenEntry = nullptr;
   for (auto *Succ : If->successors()) {
     if (Succ != Flow) {
       ThenEntry = Succ;
       break;
     }
   }
----------------
Could you also remove this piece of code for the `ThenEntry`? They are not needed anymore.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116714/new/

https://reviews.llvm.org/D116714



More information about the llvm-commits mailing list