[PATCH] D116804: [x86] use SETCC_CARRY instead of SBB node for select lowering

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 7 09:17:34 PST 2022


spatel added a comment.

In D116804#3227666 <https://reviews.llvm.org/D116804#3227666>, @craig.topper wrote:

> Are we concerned about the false dependency on Intel CPUs? I tried checking uops.info to see if I could tell what CPUs have it, but I couldn’t tell.

IMO, this is the right transform at this stage of compiling, but I don't have a strong opinion either way. The bug report ( https://github.com/llvm/llvm-project/issues/53006 ) doesn't seem to expect a zero op.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116804/new/

https://reviews.llvm.org/D116804



More information about the llvm-commits mailing list