[lld] 935229f - [ELF] Symbol::getVA: assert not called on a lazy symbol

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 5 00:46:53 PST 2022


Author: Fangrui Song
Date: 2022-01-05T00:46:48-08:00
New Revision: 935229f66bf96914a63ed9be740bb82995abbe55

URL: https://github.com/llvm/llvm-project/commit/935229f66bf96914a63ed9be740bb82995abbe55
DIFF: https://github.com/llvm/llvm-project/commit/935229f66bf96914a63ed9be740bb82995abbe55.diff

LOG: [ELF] Symbol::getVA: assert not called on a lazy symbol

The code path is dead after D111365.

Added: 
    

Modified: 
    lld/ELF/Symbols.cpp

Removed: 
    


################################################################################
diff  --git a/lld/ELF/Symbols.cpp b/lld/ELF/Symbols.cpp
index ed83b75953dd9..443bec0c111fc 100644
--- a/lld/ELF/Symbols.cpp
+++ b/lld/ELF/Symbols.cpp
@@ -133,8 +133,7 @@ static uint64_t getSymVA(const Symbol &sym, int64_t addend) {
     return 0;
   case Symbol::LazyArchiveKind:
   case Symbol::LazyObjectKind:
-    assert(sym.isUsedInRegularObj && "lazy symbol reached writer");
-    return 0;
+    llvm_unreachable("lazy symbol reached writer");
   case Symbol::CommonKind:
     llvm_unreachable("common symbol reached writer");
   case Symbol::PlaceholderKind:


        


More information about the llvm-commits mailing list