[PATCH] D115113: [InstCombine] Do not combine atomic and non-atomic loads.

[Ricky Zhou via Phabricator via llvm-commits]

rickyz added a comment.

Thanks for the reduced test case - I verified that it fails before this change and passes after.



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombinePHI.cpp:663
   // for atomic operations.
-  if (FirstLI->isAtomic())
+  const bool isAtomic = FirstLI->isAtomic();
+  if (isAtomic)
----------------
spatel wrote:
> To conform with current coding standards, this should be "IsAtomic". Fix the existing code as an NFC pre-commit?
I went through the existing variables violating the coding standards and fixed them - most of them were loop iterators that I converted to range for loops. That change is unfortunately a little larger than I'd hoped - I split those changes into D116086.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115113/new/

https://reviews.llvm.org/D115113