[PATCH] D114768: [ADT][Support] Remove zero-width assertions

Chris Lattner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 30 12:05:52 PST 2021


lattner accepted this revision.
lattner added a comment.

This revised change to `getZExtValue` only LGTM, because it is the only reasonable definition of this.  As @nikic points out, we need to be more deliberate about bigger changes: defining a zero width thing to always have zero value isn't obviously correct.

Please change the commit message to "Remove zero-width assertion from getZExtValue" to make it more specific, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114768/new/

https://reviews.llvm.org/D114768



More information about the llvm-commits mailing list