[PATCH] D111300: [VPlan] Keep induction recipes in header.

Wed Nov 10 03:44:37 PST 2021

fhahn added a comment.

In D111300#3120415 <https://reviews.llvm.org/D111300#3120415>, @dyung wrote:

> Hi, this change is hitting an assertion failure when run on one of our internal tests. I have put the details in PR52460 <https://bugs.llvm.org/show_bug.cgi?id=52460>, can you take a look?

Thanks for the report!

The issue is that sink-after for first-order recurrences might need to sink after the original truncate instruction of an optimized IV recipe, so we need to keep them in the original position until *after* sink-after. I pushed e7f1232cb777 <https://reviews.llvm.org/rGe7f1232cb777ac7408c7b4b7f5c421986bad3a82> to fix the crash. @Ayal it would be great if you could take a post-commit look, in case you have any ideas/thoughts how to resolve this differently.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111300/new/

https://reviews.llvm.org/D111300