[PATCH] D113356: [llvm-objdump] -p: Dump PE header for PE/COFF

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexander-shaposhnikov added inline comments.


================
Comment at: llvm/tools/llvm-objdump/COFFDump.cpp:166
+
+  static const char *DirName[16] = {
+      "Export Directory [.edata (or where ever we found it)]",
----------------
MaskRay wrote:
> alexander-shaposhnikov wrote:
> > constexpr ?
> constexpr applies to the object declaration (`DirName` is a constexpr) which has a different meaning: the element type will be `char*` which will lead to `-Wwrite-strings`.
> 
> `static constexpr const char *DirName[16]` works but it is just unnecessarily verbose.
Yeah, I meant the latter, perhaps, it doesn't matter much here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113356/new/

https://reviews.llvm.org/D113356