[PATCH] D112899: Update fir.insert_on_range syntax to make the range more explicit (NFC)

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: flang/lib/Optimizer/Dialect/FIROps.cpp:1483
+//   build(builder, result, resTy, aggVal, eleVal, aa);
+// }
+
----------------
clementval wrote:
> Why is this removed? 
Oh right I forgot to update this: this builder seems conceptually broken to me.
It takes an `ArrayRef<mlir::Value>` where it expects only constants.
Builders can't fail: so this does not seems like a good API: every caller will have to check that the values are constant before calling this, which will again recheck (but die).
Also the fact that it can be deleted show it isn't used right now. 

I'll pull this in another revision and rebase the current one though.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112899/new/

https://reviews.llvm.org/D112899