[PATCH] D107934: [LowerTypeTests] Emit cfi_jt aliases regardless of function export

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 26 16:32:16 PDT 2021


nickdesaulniers added inline comments.


================
Comment at: llvm/test/LTO/X86/cfi_jt_aliases.ll:1
+; RUN: opt %s -o %t.bc
+; RUN: llvm-lto2 run -o %t.o %t.bc -save-temps \
----------------
pcc wrote:
> Can this file and the ThinLTO one be combined into a single file?
Is there prior art for tests shared between llvm/test/LTO/ and llvm/test/ThinLTO/?

The IR is identical between the two.

The `RUN` lines differ slightly in the following ways:
- additional `opt` flags for thin LTO
- `-save-temps` for full LTO's invocation of `llvm-lto2`
- additional `llvm-dis` invocation for full LTO checking one of those saved temporaries.

Perhaps I could put the IR in an Inputs/ dir somewhere, then use that (//not// use `%s`) as input to `opt`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107934/new/

https://reviews.llvm.org/D107934



More information about the llvm-commits mailing list