[PATCH] D111930: Add support for Bazel builds on Windows with `clang-cl`.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 23 17:52:44 PDT 2021


chandlerc added a comment.

Updated, PTAL



================
Comment at: utils/bazel/llvm-project-overlay/llvm/unittests/BUILD.bazel:115
     name = "codegen_tests",
-    size = "small",
+    size = "medium",
     srcs = glob(
----------------
GMNGeoffrey wrote:
> Hmmm unfortunate that these have to increase specifically for windows. Do windows tests take longer overall? We could change the actual timeouts corresponding to the timeout names instead.
Tests aren't generally slower, just certain *kinds* of tests. =/

Specifically, GoogleTest's "death tests" are both much slower and have much higher variability on Windows AFAICT.

I can defer these if you want and try to get statistics on how important they are, and where. I just added these when during testing I got some timeouts.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111930/new/

https://reviews.llvm.org/D111930



More information about the llvm-commits mailing list