[PATCH] D112000: [SelectionDAG] Allow FindMemType to fail when widening loads & stores

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:5025
   SmallVector<SDValue, 16> StChain;
-  GenWidenVectorStores(StChain, ST);
+  if (GenWidenVectorStores(StChain, ST)) {
+    if (StChain.size() == 1)
----------------
RKSimon wrote:
> (style)
> ```
> if (!GenWidenVectorStores(StChain, ST))
>   llvm_unreachable("Unable to widen vector store");
> ```
Yeah fair enough. Given I'm building on top of it I thought I'd minimize the diff ahead of time, but I agree this is better as a standalone change.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:5421
+  if (!TypeSize::isKnownLE(LdWidth, FirstVTWidth)) {
+    auto NewVT = FirstVT;
+    TypeSize RemainingWidth = LdWidth;
----------------
RKSimon wrote:
> (style) It'd be better if you didn't use auto
Makes sense; it can be difficult to transition between different styles of auto usage...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112000/new/

https://reviews.llvm.org/D112000