[PATCH] D110821: [fir][NFC] Rename lenParams to typeparams in builders

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 30 06:15:24 PDT 2021


clementval created this revision.
clementval added reviewers: jeanPerier, svedanayagam, sscalpone, kiranchandramohan, jdoerfert, schweitz, pmccormick, mehdi_amini, rovka, AlexisPerry.
Herald added a project: Flang.
clementval requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Fine tuning after couple of upstreamed patches.
Rename the lenParams varaiables in buidlers to typeparams.

This patch is part of the upstreaming effort from fir-dev branch.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D110821

Files:
  flang/include/flang/Optimizer/Dialect/FIROps.td


Index: flang/include/flang/Optimizer/Dialect/FIROps.td
===================================================================
--- flang/include/flang/Optimizer/Dialect/FIROps.td
+++ flang/include/flang/Optimizer/Dialect/FIROps.td
@@ -1017,9 +1017,9 @@
     OpBuilder<(ins "llvm::ArrayRef<mlir::Type>":$resultTypes,
       "mlir::Value":$memref, CArg<"mlir::Value", "{}">:$shape,
       CArg<"mlir::Value", "{}">:$slice,
-      CArg<"mlir::ValueRange", "{}">:$lenParams),
+      CArg<"mlir::ValueRange", "{}">:$typeparams),
     [{ return build($_builder, $_state, resultTypes, memref, shape, slice,
-                    lenParams, mlir::AffineMapAttr{}); }]>
+                    typeparams, mlir::AffineMapAttr{}); }]>
   ];
 
   let assemblyFormat = [{
@@ -1027,7 +1027,7 @@
       (`map` $accessMap^)? attr-dict `:` functional-type(operands, results)
   }];
 
-  let verifier = [{ return ::verify(*this); }];
+  let verifier = "return ::verify(*this);";
 
   let extraClassDeclaration = [{
     mlir::Value getShape() { return shape(); }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110821.376176.patch
Type: text/x-patch
Size: 1038 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210930/d1275d2c/attachment.bin>


More information about the llvm-commits mailing list