[PATCH] D110372: [AMDGPU] Limit promote alloca max size in functions

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 23 17:21:59 PDT 2021


rampitec added a comment.

In D110372#3019432 <https://reviews.llvm.org/D110372#3019432>, @rampitec wrote:

> In D110372#3019431 <https://reviews.llvm.org/D110372#3019431>, @arsenm wrote:
>
>> We could also be smarter and promote only if there isn’t an intervening call between uses
>
> Why so? If the call does not take address it shall be fine. If address is taken promotion is impossible.

I think I kind of got the idea, we have to spill around the call. Maybe we shall do the same: promote, but tell our limit is 32 registers.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110372/new/

https://reviews.llvm.org/D110372



More information about the llvm-commits mailing list