[PATCH] D110143: [Utils] Replace llc with cat for tests

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added inline comments.


================
Comment at: llvm/utils/update_llc_test_checks.py:94
       llc_cmd_args = llc_cmd[len(llc_tool):].strip()
-      llc_cmd_args = llc_cmd_args.replace('< %s', '').replace('%s', '').strip()
+      llc_cmd_args = llc_cmd_args.replace('< %s', '').replace('%s', '').replace('%S', sourcedir).strip()
       if ti.path.endswith('.mir'):
----------------
Doing this in common.py would also fix the other update scripts instead of having to duplicate it everywhere.

Also I wonder if we defer to lit's expansion code instead of re-implementing lit features here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110143/new/

https://reviews.llvm.org/D110143