[PATCH] D109484: [SLP] Calculate overload types from intrinsic description

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 16 08:46:56 PDT 2021


bjope added inline comments.


================
Comment at: llvm/include/llvm/IR/Intrinsics.h:193
     ArgKind getArgumentKind() const {
-      assert(Kind == Argument || Kind == ExtendArgument ||
-             Kind == TruncArgument || Kind == HalfVecArgument ||
-             Kind == SameVecWidthArgument || Kind == PtrToArgument ||
-             Kind == VecElementArgument || Kind == Subdivide2Argument ||
-             Kind == Subdivide4Argument || Kind == VecOfBitcastsToInt);
+      assert(hasBoundType() && Kind != VecOfAnyPtrsToElt &&
+             "This descriptor does not have argument kind");
----------------
This did not assert on PtrToElt in the past? Since commit msg says that this does not affect functionality I wonder if this was an intentional change or not?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109484/new/

https://reviews.llvm.org/D109484



More information about the llvm-commits mailing list